libs/safety_manager.py (1)

264-279: 💤 Low value

Consider pre-compiling _posix_system_prefixes for consistency.

The optimization of bypassing Python's internal regex cache by pre-compiling patterns could also be applied to this local list. While the performance gain would be minor (since this method isn't called in tight loops), pre-compiling at class scope would maintain consistency with the broader optimization pattern.

♻️ Proposed refactor to pre-compile _posix_system_prefixes

Add at class level (after line 126):

	_HOST_ABSOLUTE_PATH_PREFIXES = [
		r"/etc/\w+",
		r"/tmp/\w+",
		r"/var/\w+",
		r"/usr/\w+",
		r"/root/\w+",
		r"/home/\w+/",
		r"/proc/\w+",
		r"/sys/\w+",
		r"/dev/\w+",
		r"/boot/\w+",
		r"/opt/\w+",
		r"/mnt/\w+",
		r"/media/\w+",
	]
	_HOST_ABSOLUTE_PATH_PREFIXES_COMPILED = tuple(re.compile(p, re.IGNORECASE) for p in _HOST_ABSOLUTE_PATH_PREFIXES)

Then update the method:

 	def _is_host_absolute_path(self, code: str) -> bool:
 		"""Return True if *code* references a host absolute path."""
 		# Windows drive-letter path
 		if re.search(r"[a-z]:[\\/]", code.lower()):
 			return True
 
 		# Quoted POSIX absolute path: '/...' or "/..."
 		if re.search(r"""["']/[^"'\s]""", code):
 			return True
 
-		# Unquoted well-known POSIX system directory prefixes
-		_posix_system_prefixes = [
-			r"/etc/\w+",
-			r"/tmp/\w+",
-			r"/var/\w+",
-			r"/usr/\w+",
-			r"/root/\w+",
-			r"/home/\w+/",
-			r"/proc/\w+",
-			r"/sys/\w+",
-			r"/dev/\w+",
-			r"/boot/\w+",
-			r"/opt/\w+",
-			r"/mnt/\w+",
-			r"/media/\w+",
-		]
-		if any(re.search(p, code, re.IGNORECASE) for p in _posix_system_prefixes):
+		if any(p.search(code) for p in self._HOST_ABSOLUTE_PATH_PREFIXES_COMPILED):
 			return True

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@libs/safety_manager.py` around lines 264 - 279, Replace the local
_posix_system_prefixes list with a class-level constant of raw pattern strings
(e.g. _HOST_ABSOLUTE_PATH_PREFIXES) and a precompiled tuple (e.g.
_HOST_ABSOLUTE_PATH_PREFIXES_COMPILED = tuple(re.compile(p, re.IGNORECASE) for p
in _HOST_ABSOLUTE_PATH_PREFIXES); then update the check in the method to use
any(pattern.search(code) for pattern in _HOST_ABSOLUTE_PATH_PREFIXES_COMPILED)
instead of any(re.search(p, code, re.IGNORECASE) for p in
_posix_system_prefixes) so the patterns are compiled once and reused.